Separate classes for form fields and their holders.

<%- if @topic_view.topic.tags.present? %>
<%= t 'js.tagging.tags' %>: <%- @topic_view.topic.tags.each do |t| %> <%= t %> <%- end %>
<% end %>

I feel confident that, in 2019, the status quo of CSS frameworks is that they expect different classes to be on “div” elements and “input” elements. In the case of SilverStripe, currently, the “FormField::addExtraClass()” method blindly inserts the classes on both the form field (an “input” element) and its holder (a “div” element). Wrong. The classes of the holder should be controlled by a new method, “FormField::addExtraHolderClass()” or something similar. And, before you ask, yes, I am aware that there is a method “FormField::setFieldHolderTemplate().” The problem with this method is that it requires separate templates for something as trivial as exchanging one CSS class for another when over half of the time this is all that changes between the two variants.

Stuart Simon shared this idea


Originally posted at Separate classes for form fields and their holders. – [READONLY] Community Feeback for SilverStripe CMS & Framework

This has always bothered me as well… Would love to see something like this implemented!